Skip to content

Use the selected Minikube profile in tunnel instructions - #682

Open
dprotaso wants to merge 4 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-minikube-tunnel
Open

dprotaso wants to merge 4 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-minikube-tunnel

Conversation

@dprotaso

@dprotaso dprotaso commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Quickstart always prints minikube tunnel --profile knative, even for custom names or passthrough profile overrides. The README additionally uses minikube-knative, which does not match the default profile.

Changes

  • Print the resolved cluster/profile name in the tunnel command.
  • Correct the README's default profile and document custom names.
  • Keep profile resolution in the internal profileName helper, shared by cluster setup and tunnel instructions. No new tests or output-formatting helpers are introduced.

Validation

  • go test -race ./...
  • golangci-lint run --new-from-rev=upstream/main ./... (0 issues)

Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@knative-prow

knative-prow Bot commented Nov 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot requested review from dsimansk and psschwei November 15, 2026 05:21
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2026
@dprotaso

Copy link
Copy Markdown
Contributor Author

/assign @psschwei

Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@knative-prow knative-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2026
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@knative-prow knative-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants